fix: guard getBorders() against empty lines input#11
Open
Luc0-0 wants to merge 1 commit intowebpod:mainfrom
Open
fix: guard getBorders() against empty lines input#11Luc0-0 wants to merge 1 commit intowebpod:mainfrom
Luc0-0 wants to merge 1 commit intowebpod:mainfrom
Conversation
When ps output is empty or malformed (e.g. BusyBox on Alpine), parseLines() returns an empty array and getBorders() crashes trying to access lines[0].spaces on undefined.
This was referenced Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getBorders()crashes withTypeError: Cannot read properties of undefined (reading 'spaces')when called with an empty array.This happens in practice when
@webpod/psrunsps -lxon BusyBox (Alpine Linux) — BusyBox doesn't support that flag, returns empty/malformed output,parseLines()produces[], andgetBorders()blows up onlines[0].Added an early return for empty input and a test covering it.
Related: google/zx#1369