Skip to content

fix(theme): improve destructured parameters rendering and flatten lists#167

Merged
avivkeller merged 2 commits into
webpack:mainfrom
moshams272:fix/format-destructured-parameters
Jul 4, 2026
Merged

fix(theme): improve destructured parameters rendering and flatten lists#167
avivkeller merged 2 commits into
webpack:mainfrom
moshams272:fix/format-destructured-parameters

Conversation

@moshams272

Copy link
Copy Markdown
Contributor

Summary

Developers write functions with object params the TS compiler named that object with “__namedParameters”, so we have 2 scenarios:

  • They wrote a destruct object.
  • That’s interface.

For destructed objects, This update intercepts the AST to show the actual destructed keys'names for these parameters and flattens their properties in the documentation to match the project's flat list standard, as it doesn't create the Attribute table without be flat list.

Before:

image

After:

image

For interface, we just show its name.

Before:

image

After:

image

@vercel

vercel Bot commented Jul 4, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
webpack-doc-kit Ready Ready Preview, Comment Jul 4, 2026 5:52pm

Request Review

@avivkeller avivkeller left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@bjohansebas bjohansebas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT! i like

@avivkeller

Copy link
Copy Markdown
Member

For interface, we just show its name.

Can we either just call them options, or make the first character lower case (MyInterfaceOptions -> myInterfaceOptions)?

@avivkeller avivkeller merged commit eea1c94 into webpack:main Jul 4, 2026
9 checks passed
@moshams272 moshams272 deleted the fix/format-destructured-parameters branch July 4, 2026 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants