fix: added metric for LLM connection state#4649
Merged
marcin-bazyl merged 2 commits intowebex:nextfrom Jan 15, 2026
Merged
Conversation
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
4fc1f5c to
f194f6c
Compare
jor-row
approved these changes
Jan 14, 2026
Coread
approved these changes
Jan 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
COMPLETES #SPARK-756975
This pull request addresses
We've had some bugs reported that seem to be caused by missing/not working LLM connection, we want to have metrics to know how often LLM fails
by making the following changes
As we don't want to add a metric for every successfull LLM connection, because we have cost and limits associated with amplitude metrics, we're adding just a metric when LLM is not connected 3min after we tried to establish it
Change Type
The following scenarios where tested
unit tests
The GAI Coding Policy And Copyright Annotation Best Practices
I certified that
I have read and followed contributing guidelines
I discussed changes with code owners prior to submitting this pull request
I have not skipped any automated checks
All existing and new tests passed
I have updated the documentation accordingly
Make sure to have followed the contributing guidelines before submitting.