Skip to content

fix: added metric for LLM connection state#4649

Merged
marcin-bazyl merged 2 commits intowebex:nextfrom
marcin-bazyl:spark-756975
Jan 15, 2026
Merged

fix: added metric for LLM connection state#4649
marcin-bazyl merged 2 commits intowebex:nextfrom
marcin-bazyl:spark-756975

Conversation

@marcin-bazyl
Copy link
Collaborator

COMPLETES #SPARK-756975

This pull request addresses

We've had some bugs reported that seem to be caused by missing/not working LLM connection, we want to have metrics to know how often LLM fails

by making the following changes

As we don't want to add a metric for every successfull LLM connection, because we have cost and limits associated with amplitude metrics, we're adding just a metric when LLM is not connected 3min after we tried to establish it

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tooling change
  • Internal code refactor

The following scenarios where tested

unit tests

The GAI Coding Policy And Copyright Annotation Best Practices

  • GAI was not used (or, no additional notation is required)
  • Code was generated entirely by GAI
  • GAI was used to create a draft that was subsequently customized or modified
  • Coder created a draft manually that was non-substantively modified by GAI (e.g., refactoring was performed by GAI on manually written code)
  • Tool used for AI assistance (GitHub Copilot / Other - specify)
    • Github Copilot
    • Other - Please Specify
  • This PR is related to
    • Feature
    • Defect fix
    • Tech Debt
    • Automation

I certified that

  • I have read and followed contributing guidelines

  • I discussed changes with code owners prior to submitting this pull request

  • I have not skipped any automated checks

  • All existing and new tests passed

  • I have updated the documentation accordingly


Make sure to have followed the contributing guidelines before submitting.

@marcin-bazyl marcin-bazyl requested review from a team as code owners January 8, 2026 18:32
@aws-amplify-us-east-2
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-4649.d3m3l2kee0btzx.amplifyapp.com

@marcin-bazyl marcin-bazyl added the validated If the pull request is validated for automation. label Jan 9, 2026
@marcin-bazyl marcin-bazyl merged commit 354d250 into webex:next Jan 15, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

validated If the pull request is validated for automation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants