Upgrade to Spring Boot 2.0.4#14
Open
SnuK87 wants to merge 4 commits intoweb3j:masterfrom
SnuK87:master
Open
Conversation
health endpoint web extension, add actuator-autoconfigration dependency, bump version to 2.0
|
When will release the this version? |
JohnChangUK
approved these changes
Nov 5, 2018
|
Great work, just a couple of changes which have been mentioned. |
JohnChangUK
reviewed
Nov 7, 2018
src/main/java/org/web3j/spring/autoconfigure/Web3jAutoConfiguration.java
Show resolved
Hide resolved
JohnChangUK
reviewed
Nov 7, 2018
| Web3jHealthEndpointWebExtension healthEndpoint = this.context.getBean(Web3jHealthEndpointWebExtension.class); | ||
| Health health = healthEndpoint.health(); | ||
| assertThat(health.getStatus(), equalTo(Status.DOWN)); | ||
| assertThat(health.getDetails().get("error").toString(), |
There was a problem hiding this comment.
This test fails, the error being returned is "org.web3j.exceptions.MessageDecodingException: Value must be in format 0x[1-9]+[0-9]* or 0x0".
Author
There was a problem hiding this comment.
For me all tests are green. Could you post the full stacktrace of the exception?
Contributor
There was a problem hiding this comment.
Tests seem to work for me, could it be a conflict in your env?
There was a problem hiding this comment.
Tests work fine, I had an instance of Test-RPC running on port 8545.
…ation.java Co-Authored-By: SnuK87 <d.griese1987@gmail.com>
JohnChangUK
approved these changes
Nov 9, 2018
iikirilov
approved these changes
Nov 9, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I replaced the
HealthIndicatorby a Spring Boot 2.x compliantHealthEndpointWebExtensionbecause of some major changes in the actuator library. Due to the lack of backward compatibility I bumped the version to2.0.0instead of1.7.0.Maybe it also makes sense to use the newest
Web3jversion?