[html-in-canvas] Fix inline hit testing - #62334
Open
chromium-wpt-export-bot wants to merge 1 commit into
Open
Conversation
chromium-wpt-export-bot
marked this pull request as ready for review
September 1, 2026 21:56
When an inline element has a canvas element transform, the offset from `PhysicalLinesBoundingBox` needs to be removed so the inline's origin does not include the inline's offset from its containing block, see: `LayoutInline::QuadsForSelfInternal`. This patch applies the same adjustment for LayoutInline::NodeAtPoint. Bug: 554586994 Change-Id: I3cc68e70754e1fbac0b774426a8b26c3d9dafa54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8324827 Reviewed-by: Stefan Zager <szager@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/main@{#1690128}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-8324827
branch
from
September 1, 2026 21:57
7b52078 to
4783f84
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an inline element has a canvas element transform, the offset from
PhysicalLinesBoundingBoxneeds to be removed so the inline's origindoes not include the inline's offset from its containing block, see:
LayoutInline::QuadsForSelfInternal. This patch applies the sameadjustment for LayoutInline::NodeAtPoint.
Bug: 554586994
Change-Id: I3cc68e70754e1fbac0b774426a8b26c3d9dafa54
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8324827
Reviewed-by: Stefan Zager <szager@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1690128}