[Connection-Allowlist] Enforce for cross-origin document prefetch#59919
Merged
Conversation
Enforce by passing the network restriction id to URLLoaderFactoryParamsHelper::CreateForPrefetch. The param is used by CrossOriginPrefetchLoaderFactory, which is for <link> prefetch that: - is cross-origin - having attribute `as="document"` Note: Browser test is not added for header triggered prefetch because crbug.com/40752428 makes the test flaky. The WPT that also uses header triggered prefetch somehow does not flake in try bots. Bug: 447954811, 507078585 Change-Id: I31b41b063c75026b52c28a1dbfb04f58deb10a90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7832782 Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Xiaochen Zhou <xiaochenzh@chromium.org> Reviewed-by: Andrew Verge <averge@chromium.org> Cr-Commit-Position: refs/heads/main@{#1631576}
wpt-pr-bot
approved these changes
May 15, 2026
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enforce by passing the network restriction id to
URLLoaderFactoryParamsHelper::CreateForPrefetch.
The param is used by CrossOriginPrefetchLoaderFactory, which is for
<link> prefetch that:
as="document"Note: Browser test is not added for header triggered prefetch because
crbug.com/40752428 makes the test flaky. The WPT that also uses header
triggered prefetch somehow does not flake in try bots.
Bug: 447954811, 507078585
Change-Id: I31b41b063c75026b52c28a1dbfb04f58deb10a90
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7832782
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Xiaochen Zhou <xiaochenzh@chromium.org>
Reviewed-by: Andrew Verge <averge@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1631576}