[flex-balance] Add additional negative margin test.#59918
Merged
Conversation
When performing line-breaking we should be clamping the hypothetical main size as zero, but not anything else. https://drafts.csswg.org/css-flexbox-2/#algo-balance """ For the purpose of this algorithm, a flex item’s size is its outer hypothetical main size, floored at 0. """ We do this, but add a test checking the flexing behaviour still works without clamping to zero. Bug: 416755656 Change-Id: Ia6932aec537d5a994728a4f09042986dde5111c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7851530 Reviewed-by: David Grogan <dgrogan@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/main@{#1631556}
wpt-pr-bot
approved these changes
May 15, 2026
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When performing line-breaking we should be clamping the hypothetical
main size as zero, but not anything else.
https://drafts.csswg.org/css-flexbox-2/#algo-balance
"""
For the purpose of this algorithm, a flex item’s size is its outer
hypothetical main size, floored at 0.
"""
We do this, but add a test checking the flexing behaviour still works
without clamping to zero.
Bug: 416755656
Change-Id: Ia6932aec537d5a994728a4f09042986dde5111c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7851530
Reviewed-by: David Grogan <dgrogan@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1631556}