chore: remove stale ts-node config remnants#13698
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes leftover ts-node-based config fixtures and ts-node-specific tsconfig settings, aligning the repo with the current TypeScript config loading approach (via jiti) and reducing stale maintenance surface.
Changes:
- Removed the
ts-node-registerCLI config fixture and its associated “builtin loader semantics” test. - Dropped obsolete
"ts-node"sections from varioustsconfig.jsonfiles used in tests/benchmarks andpackages/rspack. - Kept existing
jitiloader coverage inconfig.test.tsas the remaining validation path.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/e2e/tsconfig.json | Removes unused ts-node config block from e2e tsconfig. |
| tests/bench/fixtures/ts-react/tsconfig.json | Removes unused ts-node compilerOptions override from benchmark fixture. |
| packages/rspack/tsconfig.browser.json | Removes unused ts-node config from browser tsconfig. |
| packages/rspack-cli/tests/build/config/ts-node-register/tsconfig.json | Deletes obsolete fixture tsconfig. |
| packages/rspack-cli/tests/build/config/ts-node-register/rspack.config.ts | Deletes obsolete fixture rspack config. |
| packages/rspack-cli/tests/build/config/ts-node-register/main.ts | Deletes obsolete fixture entry file. |
| packages/rspack-cli/tests/build/config/config.test.ts | Removes the test suite that depended on the deleted fixture and old loader semantics. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Rsdoctor Bundle Diff AnalysisFound 6 projects in monorepo, 0 projects with changes. 📊 Quick Summary
Generated by Rsdoctor GitHub Action |
📦 Binary Size-limit
🎉 Size decreased by 5.34KB from 49.39MB to 49.38MB (⬇️0.01%) |
Merging this PR will improve performance by 4.63%
Performance Changes
Comparing |
Summary
ts-node-registerCLI config fixture and its builtin loader semantics test now that TypeScript configs are loaded viajitits-nodesections from repositorytsconfigfiles that are no longer used after the loader migrationRelated links
Checklist