Skip to content

chore(deps): upgrade chokidar to v5#1542

Merged
Timeless0911 merged 1 commit intomainfrom
david/chore/core-chokidar-v5
Mar 17, 2026
Merged

chore(deps): upgrade chokidar to v5#1542
Timeless0911 merged 1 commit intomainfrom
david/chore/core-chokidar-v5

Conversation

@Timeless0911
Copy link
Contributor

@Timeless0911 Timeless0911 commented Mar 17, 2026

Summary

Upgrade chokidar in @rslib/core from v4 to v5 and update the restart watcher to load the package via await import('chokidar').

This removes the old compiled/prebundle wiring for chokidar, so the core package bundles the dependency directly while keeping the existing watch and restart behavior unchanged.

Related Links

close: #1510

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings March 17, 2026 11:42
@Timeless0911 Timeless0911 changed the title build(core): upgrade chokidar to v5 chore(deps): upgrade chokidar to v5 Mar 17, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Upgrade chokidar usage in @rslib/core by moving from the prebundled/compiled wiring to bundling chokidar directly, while keeping restart-watch behavior the same.

Changes:

  • Bump chokidar dependency from v4 to v5.
  • Remove compiled/prebundle/externals wiring for chokidar.
  • Update restart watcher to dynamically import chokidar and use its default export.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
packages/core/tsconfig.json Removes TS path alias that redirected chokidar to the compiled copy.
packages/core/src/restart.ts Switches dynamic import usage to pull default from chokidar.
packages/core/rslib.config.ts Stops treating chokidar as an external compiled dependency so it can be bundled.
packages/core/prebundle.config.mjs Removes chokidar from the prebundle dependency list.
packages/core/package.json Upgrades chokidar version to v5.
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

@Timeless0911 Timeless0911 merged commit 350de93 into main Mar 17, 2026
14 checks passed
@Timeless0911 Timeless0911 deleted the david/chore/core-chokidar-v5 branch March 17, 2026 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants