chore(deps): upgrade chokidar to v5#1542
Merged
Timeless0911 merged 1 commit intomainfrom Mar 17, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Upgrade chokidar usage in @rslib/core by moving from the prebundled/compiled wiring to bundling chokidar directly, while keeping restart-watch behavior the same.
Changes:
- Bump
chokidardependency from v4 to v5. - Remove compiled/prebundle/externals wiring for
chokidar. - Update restart watcher to dynamically import
chokidarand use its default export.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/core/tsconfig.json | Removes TS path alias that redirected chokidar to the compiled copy. |
| packages/core/src/restart.ts | Switches dynamic import usage to pull default from chokidar. |
| packages/core/rslib.config.ts | Stops treating chokidar as an external compiled dependency so it can be bundled. |
| packages/core/prebundle.config.mjs | Removes chokidar from the prebundle dependency list. |
| packages/core/package.json | Upgrades chokidar version to v5. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
fi3ework
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrade
chokidarin@rslib/corefrom v4 to v5 and update the restart watcher to load the package viaawait import('chokidar').This removes the old compiled/prebundle wiring for
chokidar, so the core package bundles the dependency directly while keeping the existing watch and restart behavior unchanged.Related Links
close: #1510
Checklist