perf: upgrade rslog and bundle into to main chunk#1541
Merged
Timeless0911 merged 1 commit intomainfrom Mar 17, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Upgrades packages/core to rslog v2 and changes the build setup so rslog is bundled into the core runtime output while only the prebundled rslog types are used during declaration generation.
Changes:
- Bump
rslogdependency to^2.0.1. - Stop path/externals rewriting to the prebundled CJS runtime; bundle
rslogin core output instead. - Keep using prebundled
rslogtypes for DTS generation viarslibaliasing andprebundledtsOnly.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/core/tsconfig.json | Removes TS path mapping that previously redirected rslog imports to the prebundled copy. |
| packages/core/rslib.config.ts | Adds DTS alias for rslog types and stops externalizing rslog runtime. |
| packages/core/prebundle.config.mjs | Switches rslog prebundle to dtsOnly and removes CJS copy step. |
| packages/core/package.json | Upgrades rslog to v2. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
fi3ework
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrade
packages/coretorslogv2 and stop rewriting its runtime import to the prebundled CJS copy.Bundle the
rslogdependency into the main chunk to reducerequire()calls, while still aliasing its prebundled types for declaration generation so consumers no longer depend on the old compiled runtime path.Related Links
close: #1511
Checklist