fix(core): support numbered preprocessor css rules#1538
Merged
Timeless0911 merged 3 commits intomainfrom Mar 17, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates lib CSS extraction to recognize “numbered” preprocessor rule IDs (e.g., sass-1) that are generated when multiple preprocessor plugins are registered, ensuring bundleless builds still swap in libCssExtractLoader.
Changes:
- Extend rule matching logic to include numbered preprocessor rule IDs (e.g.,
sass-1,less-2) when applying the lib CSS extract loader. - Adjust bundler-chain modification to iterate over matched rule IDs instead of only the base rule ID.
- Add an integration test asserting
inspectConfig()output includes loader replacement for bothsassandsass-1.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tests/integration/javascript-api/inspect-config/index.test.ts | Adds integration coverage for numbered sass-* rules in bundleless inspect output. |
| packages/core/src/css/cssConfig.ts | Updates lib CSS extraction rule matching to handle numbered preprocessor rule IDs. |
fi3ework
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Handle bundleless CSS extraction for numbered sass / less rule ids created when multiple preprocessor plugins are registered.
This keeps lib CSS extraction working for additional preprocessor rules such as
sass-1instead of only the base rule id.Related Links
N/A
Checklist