fix(builder): use original config to check inlineScripts setting#8353
Merged
fix(builder): use original config to check inlineScripts setting#8353
Conversation
The previous fix (ece3967) changed the condition from `!config.output.inlineScripts` to `config.output.inlineScripts === undefined`, which broke the default runtime chunk inlining. In Rsbuild 2.0, the default value of `inlineScripts` changed from `undefined` to `false`, so the merged config always has `false` and the condition never matches. Fix by checking `api.getRsbuildConfig('original')` to inspect the user's original config before Rsbuild defaults are merged. This correctly distinguishes between "user didn't set inlineScripts" (should use default regex) and "user explicitly set inlineScripts: false" (should respect user's choice). Co-Authored-By: Claude Opus 4.6 <[email protected]>
✅ Deploy Preview for modernjs-byted ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
🦋 Changeset detectedLatest commit: 0d78cff The changes in this PR will be included in the next version bump. This PR includes changesets to release 109 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Rsdoctor Bundle Diff Analysis
📊 Quick Summary
📋 Detailed Reports (Click to expand)📁 bundle-diffPath:
📦 Download Diff Report: bundle-diff Bundle Diff Generated by Rsdoctor GitHub Action |
clChenLiang
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous fix (ece3967) changed the condition from
!config.output.inlineScriptstoconfig.output.inlineScripts === undefined, which broke the default runtime chunk inlining. In Rsbuild 2.0, the default value ofinlineScriptschanged fromundefinedtofalse, so the merged config always hasfalseand the condition never matches.Fix by checking
api.getRsbuildConfig('original')to inspect the user's original config before Rsbuild defaults are merged. This correctly distinguishes between "user didn't set inlineScripts" (should use default regex) and "user explicitly set inlineScripts: false" (should respect user's choice).Summary
Related Links
Checklist
pnpm run change.