Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the
ilw-quotecomponent to add support for customizable padding via a newpaddingattribute, removes the default CSS padding, and simplifies the deployment workflow by delegating it to a shared workflow. The package version is also incremented to reflect these changes.Component enhancements:
paddingattribute to theilw-quotecomponent, allowing users to customize the padding inside the component. This includes updates to the TypeScript class, the builder JSON schema, and the rendering logic to apply the custom padding or a default if not specified. [1] [2] [3]--ilw-quote--paddingand the correspondingpaddingproperty from the blockquote selector, so padding is now entirely controlled by the new attribute. [1] [2]Build and deployment:
.github/workflows/deploy.ymlwith a reference to a shared workflow, simplifying the CI/CD process.Versioning:
1.2.0to1.2.1inpackage.jsonto reflect the new feature and changes.