Update Hybrid method to support nullable alpha parameter#304
Open
mpartipilo wants to merge 8 commits intoissue-298from
Open
Update Hybrid method to support nullable alpha parameter#304mpartipilo wants to merge 8 commits intoissue-298from
mpartipilo wants to merge 8 commits intoissue-298from
Conversation
![orca-security-eu[bot]](https://avatars.githubusercontent.com/in/276244?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Secrets |  0  0  0  0 |
View in Orca |
Summary - Weaviate C# Client CoverageSummary
CoverageWeaviate.Client - 45.9%
Weaviate.Client.Analyzers - 0%
|
… Weaviate 1.36.0+ (always set AlphaParam=1.0f for pure vector search); update version-aware mocks; all tests passing
…elper Replace IAsyncLifetime + single hardcoded version with a VersionedTest() helper that runs each test body against 1.34.0, 1.35.0 and 1.36.0. Each [Fact] is an expression-bodied method delegating to the lambda; no subclasses or xUnit theory machinery needed. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
Replace VersionedTest loop with IAsyncLifetime setup reading WEAVIATE_VERSION (default 1.36.0). CI passes weaviate-version input into the new unit test step, so the version matrix naturally covers unit tests alongside integration tests. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
Unit tests are version-sensitive (WEAVIATE_VERSION env var) so they belong in the per-version job, not preflight. Analyzer tests remain. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
Unit tests require no Docker, so running them first avoids spinning up Weaviate when unit tests fail. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
- Remove spurious 'async' from sync-only test method - Bump actions/cache v4 -> v5, tj-actions/changed-files v46 -> v47 to silence Node.js 20 deprecation warnings Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
HTML/JS/CSS compresses very well; compression-level 9 reduces artifact storage and download size with no change to content. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhance the gRPC client to accept a nullable alpha parameter for allowing the server to determine the default value to sue.
Adjustments ensure backward compatibility with earlier server versions while updating documentation to reflect these changes.