C10m validation#74
Open
ezrakilty wants to merge 3 commits into
Open
Conversation
yinamy
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't know that we necessarily want to change around the benchmark like this, but the first commit does demonstrate the problem. I have to interleave two fibers to show that the local variables are overwritten between fibers, hence the extra complexity in the main loop. Probably a better way to get at that bug is to have a program more similar to
pithat demonstrates it; of course in pi there's no distinguishability between the fibers, so we need to think.Anyway, the latter commits fix two bugs: