fix(perfmap): support shared libraries (append to file)#6163
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates perfmap generation to better support scenarios where multiple shared libraries/modules are loaded into the same process, avoiding overwriting /tmp/perf-{pid}.map and reducing unnecessary work.
Changes:
- Open
/tmp/perf-{pid}.mapin append mode (create if missing) instead of truncating on each call. - Only emit perfmap entries for functions that have an explicit name (skip unnamed).
- Remove per-iteration flushing while writing perfmap entries.
syrusakbary
approved these changes
Feb 4, 2026
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
marxin
force-pushed
the
fix-perfmap-with-modules
branch
from
3852c2f to
e8168b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed that when using multiple shared libraries, the
/tmp/perf-{pid}.mapfile was being overwritten. Also, we don’t need to replicate addresses for unnamed symbols, and there’s no need to flush on every loop iteration.