Improved Stack Blur algorithm with its optimized version#112
Open
KaustubhPatange wants to merge 2 commits intowasabeef:mainfrom
Open
Improved Stack Blur algorithm with its optimized version#112KaustubhPatange wants to merge 2 commits intowasabeef:mainfrom
KaustubhPatange wants to merge 2 commits intowasabeef:mainfrom
Conversation
|
I have merged your chances to my branch, and made some performance tests. See the other pull-request. I've made the code multi-threaded, but the blur is incorrect when running in multiple theads. I left the multi-thread code but disabled it. See my branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
The original stack blur algorithm with its optimized version.
What is the value of this and can you measure success?
The optimized stack blur or you can say multi-threaded stack blur. In this version, the horizontal & the vertical pixels are processed at the same time instead of the nested loop which is enough to provide a good performance benefit.
Considering this (above) the original stack algorithm skips 1-2 frame at the start (not much noticeable if done asynchronously). Since the new algorithm process rows & columns simultaneously this is not seen so far. I've kept the original implementation for you to compare the benchmarks.
Comparison
On average the optimized version takes 200ms less than the original one. I can't provide you a good metric but this is what I got when tested on Android API 21, 23, 27 & 29.
It is necessary that you first compare the two methods on your device as well. Since this project has no instrumentation tests it would be hard to automate it.