fix: use child entity path for wireframe to inherit parent transform#407
Merged
mahsumdemirwb merged 2 commits intomainfrom Mar 11, 2026
Merged
fix: use child entity path for wireframe to inherit parent transform#407mahsumdemirwb merged 2 commits intomainfrom
mahsumdemirwb merged 2 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a visualization bug in nova_rerun_bridge where wireframe outlines for ConvexHull and RectangularCapsule geometries were not inheriting the parent entity's transform in Rerun. By changing the entity path separator from _ to /, the wireframe becomes a child entity and automatically inherits the parent transform via Rerun's entity hierarchy.
Changes:
- Entity path for wireframe entities changed from
{entity_path}_wireframe(flat sibling) to{entity_path}/wireframe(child entity) for bothConvexHullandRectangularCapsulegeometry types ininit_geometry.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
mahsumdemirwb
approved these changes
Mar 9, 2026
mahsumdemirwb
requested review from
biering,
functionistic and
langenhagen
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.