Skip to content

fix: ping the js components version#401

Merged
mahsumdemirwb merged 1 commit intomainfrom
no-ticket-pin-js-components
Feb 20, 2026
Merged

fix: ping the js components version#401
mahsumdemirwb merged 1 commit intomainfrom
no-ticket-pin-js-components

Conversation

@mahsumdemirwb
Copy link
Collaborator

@mahsumdemirwb mahsumdemirwb commented Feb 20, 2026

wandelbots-js-react-components removed robot models in v4. It creates side effect on the download-models script, because the script always uses latest version. With this MR we are pinning to v3 which contains all the robot models

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR changes the robot models download script from fetching the latest release dynamically to using a pinned version (3.7.4) of the wandelbots-js-react-components repository. This provides more stability and reproducibility by ensuring all users download the same model version.

Changes:

  • Replaced dynamic latest release fetching with pinned version constants
  • Renamed get_latest_release_version() to get_pinned_release_version() to reflect the new behavior
  • Removed API call to GitHub for fetching the latest release
Comments suppressed due to low confidence (1)

nova_rerun_bridge/helper_scripts/download_models.py:12

  • The constant PINNED_COMPONENTS_RELEASE_ID is defined but never used in the code. If this release ID is not needed for the current implementation, it should be removed to avoid confusion. If it will be used in the future, consider adding a comment explaining its purpose.
PINNED_COMPONENTS_RELEASE_ID = "285774921"

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mahsumdemirwb
Copy link
Collaborator Author

@functionistic
I am merging this MR without waiting for the pipeline to be green because of the following reasons:

  • it is important for the customer and I already waited around 1 hour for the pipeline
  • It looks like the tests for short trajectory execution is sometimes failing and sometimes passing. ( it one retry, 3 tests failed, short trajectories and the pause on io trajectory, the one added recently)
  • The changes have nothing to the with trajectory, only download-models script

@mahsumdemirwb mahsumdemirwb merged commit 61d20dc into main Feb 20, 2026
29 of 32 checks passed
@mahsumdemirwb mahsumdemirwb deleted the no-ticket-pin-js-components branch February 20, 2026 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants