fix: ping the js components version#401
Merged
mahsumdemirwb merged 1 commit intomainfrom Feb 20, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR changes the robot models download script from fetching the latest release dynamically to using a pinned version (3.7.4) of the wandelbots-js-react-components repository. This provides more stability and reproducibility by ensuring all users download the same model version.
Changes:
- Replaced dynamic latest release fetching with pinned version constants
- Renamed
get_latest_release_version()toget_pinned_release_version()to reflect the new behavior - Removed API call to GitHub for fetching the latest release
Comments suppressed due to low confidence (1)
nova_rerun_bridge/helper_scripts/download_models.py:12
- The constant PINNED_COMPONENTS_RELEASE_ID is defined but never used in the code. If this release ID is not needed for the current implementation, it should be removed to avoid confusion. If it will be used in the future, consider adding a comment explaining its purpose.
PINNED_COMPONENTS_RELEASE_ID = "285774921"
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
functionistic
approved these changes
Feb 20, 2026
Collaborator
Author
|
@functionistic
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wandelbots-js-react-components removed robot models in v4. It creates side effect on the download-models script, because the script always uses latest version. With this MR we are pinning to v3 which contains all the robot models