-
Notifications
You must be signed in to change notification settings - Fork 53
style: apply /style-guide pass to models/tables #2725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
johndmulhausen
wants to merge
12
commits into
main
Choose a base branch
from
style-guide/models-tables-20260604-114339
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
8c4bc36
style: apply /style-guide pass to models/tables
johndmulhausen 7910ed9
fix: address review feedback on models/tables style pass
johndmulhausen f3e9dc7
style: drop keywords frontmatter from models/tables pages
johndmulhausen 8547adc
Merge remote-tracking branch 'origin/main' into style-guide/models-ta…
johndmulhausen 2fdf6a6
style: address mdlinville review feedback on models/tables
johndmulhausen 88e943a
Merge branch 'main' into style-guide/models-tables-20260604-114339
mdlinville b6be0e6
docs: clarify table vs artifact wording in log_tables
johndmulhausen 6ed9760
style: address ngrayluna review on models/tables
johndmulhausen 0c1c4b8
Apply suggestion from @johndmulhausen
johndmulhausen b056509
Apply suggestion from @johndmulhausen
johndmulhausen f12d9e3
Apply suggestion from @mdlinville
johndmulhausen eb6c0af
Merge remote-tracking branch 'origin/main' into style-guide/models-ta…
johndmulhausen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The nesting depth here makes me wonder if this page should be split up into at least two. Maybe the second page starts around line 137.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed the nesting is deep. I have left the page split as a follow-up rather than doing it in this style pass, since a split needs a new page plus nav and redirect updates. Happy to open a separate PR for it if you want — leaving this thread open for your call.
🤖 Addressed by Claude Code