Skip to content

[WAL-896] feat(verifier2): expose authenticated request objects - #2055

Closed
szijpeter wants to merge 1 commit into
mainfrom
feature/wal-896-verifier
Closed

[WAL-896] feat(verifier2): expose authenticated request objects#2055
szijpeter wants to merge 1 commit into
mainfrom
feature/wal-896-verifier

Conversation

@szijpeter

@szijpeter szijpeter commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Summary

This PR isolates the verifier-side OpenID4VP Request Object changes needed by the WAL-896 stack. Signed cross-device sessions now expose an authenticated compact Request Object on the full authorization URL, while request_uri POST retrieval stays available for nonce-bound bootstrap.

It is rebased onto current main after walt-id/waltid-identity#2031 (WAL-1261 kid handling). The dependent wallet PR is walt-id/waltid-identity#1885. Enterprise CI companion: walt-id/waltid-identity-enterprise#604.

What Changed

  • Signed inline cross-device sessions now expose the authenticated compact Request Object in the full authorization URL and drop request_uri from that URL.
  • DC API sessions keep request_uri-based authorizationRequestUrl construction.
  • The bootstrap URL remains the request_uri entry point for wallets that need nonce-bound POST retrieval.
  • Request URI POST coverage verifies the Request Object with Verifier2RequestObjectKid.forClient and the original signing key, rather than comparing Crypto2 key IDs to kid.

Architecture Notes

  • This branch contains verifier producer behavior only. Wallet resolver, wallet presentation, DC API, response-encryption, mobile-model, iOS, and Enterprise product changes remain in the dependent PRs.
  • WAL-1261 already landed on main: Verifier2RequestObjectKid, request_uri POST requireMatchingKeyId, and setup.withCoreKeyIfMissing. This PR does not replace that kid contract.
  • Signed-URL inlining is limited to cross-device so DC API sessions are not rewritten onto a compact request JWT.

Caveats and Follow-Ups

Breaking

  • No public API or wire-format removal is introduced; the signed Request Object behavior is made consistent with the OpenID4VP contract.

@linear-code

linear-code Bot commented Aug 6, 2026

Copy link
Copy Markdown

WAL-896

@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: c092aa45-9fc9-4ae5-b5ea-e413a25df683

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@szijpeter szijpeter self-assigned this Aug 6, 2026
@szijpeter
szijpeter force-pushed the feature/wal-896-verifier branch 5 times, most recently from 33b2f8c to 28a6a7c Compare August 7, 2026 14:11
Base automatically changed from fix/wallet-cleanup to main August 7, 2026 15:22
@JakeFernandes98
JakeFernandes98 force-pushed the feature/wal-896-verifier branch 2 times, most recently from f6b304d to ea22deb Compare August 13, 2026 12:16
@JakeFernandes98
JakeFernandes98 marked this pull request as ready for review August 13, 2026 12:20
@JakeFernandes98
JakeFernandes98 force-pushed the feature/wal-896-verifier branch 2 times, most recently from 8296069 to 437b624 Compare August 20, 2026 08:32
@JakeFernandes98
JakeFernandes98 force-pushed the feature/wal-896-verifier branch 3 times, most recently from 38cab45 to 2a32e57 Compare August 20, 2026 19:18
Co-authored-by: Cursor <cursoragent@cursor.com>
@JakeFernandes98
JakeFernandes98 force-pushed the feature/wal-896-verifier branch from 2a32e57 to 39481a2 Compare August 21, 2026 10:49
@sonarqubecloud

Copy link
Copy Markdown

@JakeFernandes98

Copy link
Copy Markdown
Contributor

Superseded by folding the WAL-896 identity stack into #2091, which now targets main and includes this verifier work plus the wallet and DC API follow-ups.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants