Bundle precompiled antlr parser - #459
Merged
Merged
Conversation
Member
|
I'm quite interested in this, but there are now conflicts that need to be resolved. |
namenu
force-pushed
the
precompiled-antlr
branch
from
October 9, 2025 12:11
ff4bae4 to
b24e3d0
Compare
namenu
marked this pull request as draft
October 9, 2025 12:19
namenu
force-pushed
the
precompiled-antlr
branch
from
October 9, 2025 12:32
fdc708a to
adc0083
Compare
undo irrelavent fixes.
namenu
marked this pull request as ready for review
October 9, 2025 15:04
Contributor
Author
|
@hlship I resolved the conflicts and updated the ANTLR version to the latest one. |
namenu
force-pushed
the
precompiled-antlr
branch
from
October 9, 2025 15:35
09463ad to
57de211
Compare
Member
|
This is looking quite good! |
hlship
approved these changes
Oct 9, 2025
Member
|
Outstanding work, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #454
Transitive dependency will be changed as follows.
com.ibm.icu/icu4jorg.antlr/ST4org.abego.treelayout/org.abego.treelayout.coreorg.antlr/antlr-runtimeclj-antlr/clj-antlrorg.antlr/antlr4org.glassfish/javax.jsonorg.antlr/antlr4-runtimeThis changes has been tested quite widely in our production system.
However, it is a big change as @hlship mentioned and I look forward to seeing it deployed in 1.3.