Open
Conversation
Member
|
Let's send We should however, send the file name as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-PR Checklist
npm testlocally and there are no warnings or errors, from lint or testSummary
There is an issue with the current implementation and it is that I could not find the concept of project while working with it, so this PR sends a heartbeat the name of the current file/notebook as
project, if the user navigates into multiple files in its session in Jupyter it will create a very long list of projects in its dashboard, which is not ideal IMO (see screenshot bellow) @alanhamlett maybe do you have more expertise with Jupyter and will know how to get a correct value to send asprojecton each heartbeat?Screenshots
Issue
#82
Reviewers