feat(check): retire the thinking-disabled workaround — effort buys extended thinking#153
Merged
Merged
Conversation
This was referenced Jul 2, 2026
Contributor
Author
RobbieMcKinstry
force-pushed
the
enable-check-agent-thinking
branch
from
bd475d2 to
749b5d8
Compare
RobbieMcKinstry
force-pushed
the
fix-check-agent-timeouts
branch
from
ee7136e to
beb8168
Compare
RobbieMcKinstry
force-pushed
the
enable-check-agent-thinking
branch
from
749b5d8 to
7c36a81
Compare
RobbieMcKinstry
force-pushed
the
fix-check-agent-timeouts
branch
from
beb8168 to
76d50c1
Compare
RobbieMcKinstry
force-pushed
the
enable-check-agent-thinking
branch
from
7c36a81 to
2c8476f
Compare
RobbieMcKinstry
force-pushed
the
fix-check-agent-timeouts
branch
from
76d50c1 to
c8c9318
Compare
RobbieMcKinstry
force-pushed
the
enable-check-agent-thinking
branch
from
2c8476f to
5985fa9
Compare
…tended thinking The cersei pin predated the provider's ability to round-trip Anthropic thinking blocks: its SSE parser dropped `signature_delta`, so the thinking block echoed back on the second turn carried an empty signature and the API rejected it. Effort was therefore applied as a sampling temperature, with a comment promising to revisit once fixed upstream. wack/cersei (now the authoritative source; we are not tracking pacifio upstream) carries the fixes: 94f18b2 accumulates the signature from `signature_delta` and 5bd06db preserves `redacted_thinking` across turns. Bump the pin (d485d50 -> 4dfac7f — which also brings the bounded, gitignore-aware GlobTool that closes the unbounded-walk timeout vector) and map effort onto its natural vehicle: - medium/high enable extended thinking (4096/8192-token budgets, cersei's own EffortLevel scale, safely under the 16k default max_tokens); - low — the default — keeps thinking off for speed and cost, steering with temperature exactly as before (0.0, +0.5 per retry attempt). Exactly one control is applied per run: the API rejects a temperature when thinking is enabled (thinking samples at 1.0, which also gives thinking retries the trajectory diversity that attempt_temperature provides on thinking-free runs). Not yet verified against the live API (no credentials in the build environment): a `multi check --effort medium` run on a real project should confirm turn-2 thinking blocks are accepted before this merges. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VxKv1hhPZ4GocfmwHUk1G8
RobbieMcKinstry
force-pushed
the
enable-check-agent-thinking
branch
from
5985fa9 to
c0ecadb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cersei pin predated the provider's ability to round-trip Anthropic
thinking blocks: its SSE parser dropped
signature_delta, so the thinkingblock echoed back on the second turn carried an empty signature and the API
rejected it. Effort was therefore applied as a sampling temperature, with a
comment promising to revisit once fixed upstream.
wack/cersei (now the authoritative source; we are not tracking pacifio
upstream) carries the fixes: 94f18b2 accumulates the signature from
signature_deltaand 5bd06db preservesredacted_thinkingacross turns.Bump the pin (d485d50 -> 4dfac7f — which also brings the bounded,
gitignore-aware GlobTool that closes the unbounded-walk timeout vector)
and map effort onto its natural vehicle:
own EffortLevel scale, safely under the 16k default max_tokens);
temperature exactly as before (0.0, +0.5 per retry attempt).
Exactly one control is applied per run: the API rejects a temperature when
thinking is enabled (thinking samples at 1.0, which also gives thinking
retries the trajectory diversity that attempt_temperature provides on
thinking-free runs).
Not yet verified against the live API (no credentials in the build
environment): a
multi check --effort mediumrun on a real project shouldconfirm turn-2 thinking blocks are accepted before this merges.
Co-Authored-By: Claude Fable 5 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01VxKv1hhPZ4GocfmwHUk1G8