Add race-network-and-cache source to static routing api. #1764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

monica-ch wants to merge 9 commits into w3c:main from monica-ch:SW-Race-NetworkRace

Collaborator

monica-ch commented Apr 16, 2025 •

edited by pr-preview bot

Loading

This PR adds new source race-network-and-cache to the SW static routing api per https://github.com/WICG/service-worker-static-routing-api/blob/main/final-form.md.

monica-ch requested a review from yoshisatoyanagisawa

April 16, 2025 05:42

Collaborator Author

monica-ch commented Apr 16, 2025

@yoshisatoyanagisawa PTAL when you get a chance, thanks!

yoshisatoyanagisawa reviewed

View reviewed changes

docs/index.bs Outdated Show resolved Hide resolved

Collaborator

yoshisatoyanagisawa commented Apr 16, 2025

@sisidovski Will you take a look?
I assume it mostly fine but I feel all failure scenarios may not work well for both race-network-and-fetch-event and race-network-and-cache.

yoshisatoyanagisawa reviewed

View reviewed changes

docs/index.bs Outdated Show resolved Hide resolved

yoshisatoyanagisawa reviewed

View reviewed changes

docs/index.bs Outdated Show resolved Hide resolved

yoshisatoyanagisawa reviewed

View reviewed changes

docs/index.bs Outdated Show resolved Hide resolved

yoshisatoyanagisawa reviewed

View reviewed changes

docs/index.bs Outdated Show resolved Hide resolved

sisidovski reviewed

View reviewed changes

docs/index.bs Show resolved Hide resolved

docs/index.bs Outdated Show resolved Hide resolved

yoshisatoyanagisawa reviewed

View reviewed changes

docs/index.bs Outdated Show resolved Hide resolved

sisidovski mentioned this pull request

ServiceWorkerAutoPreload #1756

Merged

yoshisatoyanagisawa mentioned this pull request

Fix: race-network-and-fetch-handler now uses actual |raceResponse| #1777

Merged

yoshisatoyanagisawa mentioned this pull request

TPAC 2025 status report #1787

Open

monica-ch closed this

monica-ch force-pushed the SW-Race-NetworkRace branch from 3305a7f to 3ff30ad Compare

January 20, 2026 19:04

monica-ch added 6 commits

January 21, 2026 22:52


          add race-network-and-cache

7f8c219


          minor format fixes

439fcbb


          Follow spec format

97a7763


          use helper algorithm

5b069e4


          use |raceResponse| when empty

d0b356a


          update the race-network-and-cache according to the recent timing info…

9a064e4

… changes

monica-ch reopened this

monica-ch added 2 commits

January 22, 2026 11:48


          fix LF

203a2ec


          remove |raceResponse|

28f35e4

Collaborator Author

monica-ch commented Jan 22, 2026

@yoshisatoyanagisawa Can you please review the recent changes - removed networkFetchCompleted and fetchHandlerCompleted that was introduced in the PR earlier and incorporated timingInfo per the recent changes in the cache/race-network-and-cache algorithm.

yoshisatoyanagisawa reviewed

View reviewed changes

index.bs Outdated Show resolved Hide resolved

yoshisatoyanagisawa reviewed

View reviewed changes

index.bs Outdated Show resolved Hide resolved

yoshisatoyanagisawa reviewed

View reviewed changes

index.bs Show resolved Hide resolved

Collaborator

yoshisatoyanagisawa commented Jan 27, 2026

Thanks for the contribution. Overall it looks good except the raceNetworkAndCacheCacheName source support.
To reduce the algorithm duplication, I hope cache lookup algorithms are factored out.


          address to feedback to use |cacheName|

74b0278

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet