Fix for the Table of Contents (fix #2896)#2897
Open
wszymanski wants to merge 2 commits intovuejs:masterfrom
Open
Fix for the Table of Contents (fix #2896)#2897wszymanski wants to merge 2 commits intovuejs:masterfrom
wszymanski wants to merge 2 commits intovuejs:masterfrom
Conversation
It will be created properly when paragraph is a link - boosted `slugify` method.
Siemienik
approved these changes
Jul 15, 2021
There was a problem hiding this comment.
I confirm that works perfectly:muscle:
Example:
| Header | Current output | Expected output |
|---|---|---|
## [Test](/have/a/nice/day) |
test-have-a-nice-day |
test |
For me it was required to makes Table of Contents ([[toc]]) works.
@wszymanski Thank you!
ulivz
reviewed
Dec 18, 2021
Member
ulivz
left a comment
There was a problem hiding this comment.
Thanks for your work, could you help write a unit test for slugify function?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The table of Contents will be created properly when paragraph is a link - boosted
slugifymethod.Summary
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx], where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)