fix(vue3-jest): interop custom transformer require#391
Merged
lmiller1990 merged 1 commit intovuejs:masterfrom Nov 28, 2021
Merged
Conversation
interop custom transformer require. Some transformers may not interop correctly when requiring, return `transformer.default` or `transformer`. fixes vuejs#383
cexbrayat
reviewed
Oct 1, 2021
Member
cexbrayat
left a comment
cexbrayat
left a comment
There was a problem hiding this comment.
Thanks for the PR! It would be great to add a test for this. Do you have an example of such a transformer? If so you can add a test in the e2e test directory, it's fairly straightforward. That way we're making sure we fix the proper thing and we will not have regressions in the future.
Member
Author
|
Sure. I'll add a test this morning. This happens with babel-jest. The use case here is when loading babel-jest for TS transformation. This is done when Babel is used for transformation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
interop custom transformer require. Some transformers may not interop correctly when requiring, return
transformer.defaultortransformer.@vue/vue2-jest fix: #390
fixes #383