build: add production build for every build type#2959
Open
build: add production build for every build type#2959
Conversation
Change the rollup config to also build pinia for esm browsers prod It will remove devtools and minify the code Closes vuejs#2205
✅ Deploy Preview for pinia-official canceled.
|
Doodidan
changed the title
Contributor
|
I was checking the build of this PR, I believe dev-tools dependency is being bundled, which is not ideal for prod usage |
Author
|
@porfirioribeiro Thank you, I have fixed this. |
posva
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify build config generation to make production and minified version for every build type
Also make it to use same config logic for every build type so no more of hardcoding file name needed
Closes #2205
Based on #2939