Open
Conversation
In cppia, script files are not known initially so breakpoints will fail to be set properly. With this patch, the debug server now assigns its own breakpoint id for failed breakpoints and attempts to readd them whenever a new cppia script is loaded.
Haxe 5 now generates absolute debug paths by default for cppia. If haxe 5 is not being used, a warning will already be shown earlier on anyway.
Contributor
|
Everything has been merged now, can this be merged? 👀 |
|
Bump. How goes this? |
Contributor
Author
|
This should be ready to merge since all the other PRs are merged. Note, it doesn't get debugging working fully (no local variable view etc), but at least the breakpoints are no longer ignored completely. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In cppia, script source files are not known initially so breakpoints will fail to be set properly.
With this patch, the debug server now assigns its own breakpoint id for failed breakpoints and attempts to readd them whenever a new cppia script is loaded.
This depends on the following patches to haxe and hxcpp: