Open
Conversation
jacobmarks
suggested changes
Sep 10, 2023
Contributor
jacobmarks
left a comment
jacobmarks
left a comment
There was a problem hiding this comment.
Can you include some exposition in the notebook? It's okay if the contents are very similar to the contents of the T&T blog post, but if you're going to make an examples notebook, it should also be able to stand on its own
| <img src="https://user-images.githubusercontent.com/25985824/104792428-60f9cc00-576c-11eb-95a4-5709d803023a.png" height="22" width="22"> | ||
| </a> | ||
| </td> | ||
| <td><a href="examples/Grouped Datasets.ipynb">Dynamic Group Tips & Tricks</a></td> |
Contributor
There was a problem hiding this comment.
You're linking to the wrong notebook
| <img src="https://user-images.githubusercontent.com/25985824/104792428-60f9cc00-576c-11eb-95a4-5709d803023a.png" height="22" width="22"> | ||
| </a> | ||
| </td> | ||
| <td><a href="examples/Grouped Datasets.ipynb">Dynamic Group Tips & Tricks</a></td> |
Contributor
There was a problem hiding this comment.
Great that it's in the README, but it still isn't in the index.yaml. Can you add those changes to the PR as well?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Added Dynamic Group examples