Skip to content

Approval requests#1083

Open
MaciekVoucherify wants to merge 5 commits intomasterfrom
MK-approval-requests
Open

Approval requests#1083
MaciekVoucherify wants to merge 5 commits intomasterfrom
MK-approval-requests

Conversation

@MaciekVoucherify
Copy link
Collaborator

No description provided.

@MaciekVoucherify MaciekVoucherify self-assigned this Feb 4, 2026
@MaciekVoucherify MaciekVoucherify added Documentation Improvements or additions to the documentation DO NOT MERGE Documentation-team Managed by the Documentation team Articles Changes to articles or new article labels Feb 4, 2026
Approval behavior depends on the limitations set in the custom role:

- **Created campaigns must be approved**
Users can create campaigns, but the campaign is disabled and requires approval before activation.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

campaign is not disabled - campaign, when created new by the user with limited permissions, is not displpayed on the campaign lists at all - it is only listed in the "My approval requests" of the selected approver
The campaign is added to the campaigns list after it is approved by the approver

when campaign is modified, its state is not changed and changes are not applied until approver saves it.
When an approver saves the changed (approves the approval request) then there is an event created "campaign updated" and at this moment changes are applied

- **Created campaigns and updates must be approved**
Campaign creation and all later changes require approval before they are applied.

These settings define whether approval is a simple or a more complex workflow.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't undestant this sentence - approval doesn't have miltiple workflow options: user asks for the approval and approver approves or adds comments and reject or updates on their own and approves.

<Step title="Start a restricted action">
Begin an action that requires approval, such as creating a campaign or editing a validation rule.
</Step>
<Step title="Add approvers">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Between the start and the step when the approver is selected, there is the whole configuration. it is worth pointing out that the approval is the last editable step in the configurator, so you choose the approver after you complete creating or editing

## Viewing and editing requests

After submission, you are redirected to **Approval requests**.

Copy link
Collaborator

@joannaglow joannaglow Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not neccessarily - you can log in and not be redirected to approval requests.

I'm not sure also about sections titles:
at some point in the doc I was lost whether you write about requester or approver perspective (somewhere between lines 89 an 121)

When a user with limited permissions creates a campaign, it is **not visible in the campaign list**.
Instead, it appears only in the **Approval requests** view for the selected approvers.
The campaign is added to the campaign list **after an approver approves the request**.
### Campaign creation requires approval
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This title and the one in raw 51 make no sense

Please change to sth like:
Campaign creation
Campaign update

Or put these sections in one and just differentiate how the update looks like and creation looks like in the dashboard before the approval


- When a restricted user modifies a campaign, the **current campaign state remains unchanged**.
- The changes are saved as an **approval request**.
- After an approver approves the request, the changes are applied and the **`campaign updated` event** is generated.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please leave only:
After an approver approves the request, the changes are applied.

I have added info about the event as an explanation for you, but it would be rather useless for users here.

@joannaglow
Copy link
Collaborator

I'm not convinced whether Campaign update and Campaign creation should be separate sections, while we have also Voucher creation, Voucher update, Validate rules... approval flows and they are not specified.
Maybe a change to more general: update vs. create - that when creating the new object (campaign or voucher), it is not visible in the dashboard, and update - the object is in the old form until the approver accepts?

what do you think @p-woznikowski ?

@p-woznikowski
Copy link
Collaborator

I'm not convinced whether Campaign update and Campaign creation should be separate sections, while we have also Voucher creation, Voucher update, Validate rules... approval flows and they are not specified. Maybe a change to more general: update vs. create - that when creating the new object (campaign or voucher), it is not visible in the dashboard, and update - the object is in the old form until the approver accepts?

I agree; make two sections as Asia suggests – one for Create, the other for Update, and there you can exemplify with campaigns, if needed.

Then the whole ## Campaign approval behavior section can be gotten rid of and the Create, Update behaviour can be moved to the ## How approval requests work section.

Copy link
Collaborator

@joannaglow joannaglow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good, thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Articles Changes to articles or new article DO NOT MERGE Documentation Improvements or additions to the documentation Documentation-team Managed by the Documentation team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants