change disaggragation to disaggregation#793
Conversation
Signed-off-by: zhoujinyu <[email protected]>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily addresses a pervasive typo, changing 'disaggragation' to 'disaggregation' across various components of the repository. This includes renaming example YAML configuration files, updating their internal content to reflect the correct spelling, and adjusting all corresponding references in the user guide documentation and end-to-end tests. The aim is to improve accuracy and consistency in the codebase and documentation. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Pull request overview
This PR fixes a typo in filenames, Kubernetes resource names, and documentation links: "disaggragation" → "disaggregation". It addresses issue #792.
Changes:
- Renamed example YAML files and fixed internal resource names to use the correct spelling "disaggregation"
- Updated test code file paths to reference the corrected filenames
- Updated documentation links across all versioned docs to point to the renamed files
Reviewed changes
Copilot reviewed 8 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
test/e2e/router/shared.go |
Updated three file path references from disaggragation to disaggregation |
examples/kthena-router/ModelServing-ds1.5b-pd-disaggregation.yaml |
New file with correct spelling (replaces the old misspelled version) |
examples/kthena-router/ModelServer-ds1.5b-pd-disaggregation.yaml |
Fixed internal resource name field spelling |
examples/kthena-router/ModelRoute-ds1.5b-pd-disaggregation.yaml |
New file with correct spelling (replaces deleted ModelRoute-ds1.5b-pd-disaggragation.yaml) |
examples/kthena-router/ModelRoute-ds1.5b-pd-disaggragation.yaml |
Deleted the old misspelled file |
docs/kthena/docs/user-guide/router-routing.md |
Updated documentation links to corrected filenames |
docs/kthena/docs/assets/examples/kthena-router/ModelServer-ds1.5b-pd-disaggregation.yaml |
New asset file with correct spelling |
docs/kthena/versioned_docs/version-v0.1.0/user-guide/router-routing.md |
Updated documentation links to corrected filenames |
docs/kthena/versioned_docs/version-v0.1.0/assets/examples/kthena-router/ModelServer-ds1.5b-pd-disaggregation.yaml |
New asset file with correct spelling |
docs/kthena/versioned_docs/version-v0.2.0/user-guide/router-routing.md |
Updated documentation links to corrected filenames |
docs/kthena/versioned_docs/version-v0.2.0/assets/examples/kthena-router/ModelServer-ds1.5b-pd-disaggregation.yaml |
New asset file with correct spelling |
docs/kthena/versioned_docs/version-v0.3.0/user-guide/router-routing.md |
Updated documentation links to corrected filenames |
docs/kthena/versioned_docs/version-v0.3.0/assets/examples/kthena-router/ModelServer-ds1.5b-pd-disaggregation.yaml |
New asset file with correct spelling |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request addresses a typo by changing 'disaggragation' to 'disaggregation' throughout the repository. No security vulnerabilities were found. The changes are consistently applied to filenames, file content in YAML configurations and documentation, and references within Go test files, improving the overall quality of the codebase.
|
Only |
It's easy to fail. I'm fixing 🤔 |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: YaoZengzeng The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #792
Special notes for your reviewer:
Does this PR introduce a user-facing change?: