Conversation
|
👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review. Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed. |
Summary of ChangesHello @kylesayrs, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces comprehensive support for disk offloading, enabling the quantization of very large models that exceed available CPU or GPU memory. The changes streamline the offloading process by removing redundant dispatch handling, integrating Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces support for disk offloading for large models, a valuable feature. The changes are well-structured and include updates to handle model state conversion for offloading, modifications to the saving process, and the addition of helpful example scripts. My review focuses on a few minor areas for improvement to enhance code clarity and remove redundancy. Specifically, I've pointed out a redundant argument in the new example files and an unused variable resulting from the refactoring. Addressing these points will make the code cleaner and more maintainable. Overall, this is a solid contribution.
Signed-off-by: Kyle Sayers <[email protected]>
Signed-off-by: Kyle Sayers <[email protected]>
Signed-off-by: Kyle Sayers <[email protected]>
84a7f80 to
43bdec4
Compare
Signed-off-by: Kyle Sayers <[email protected]>
Purpose
Prerequisites
Examples
examples/disk_offloading/qwen3_example.pyexamples/disk_offloading/kimi_k2_example.pyChanges
Required
remove_dispatchis calleddispatch_for_sequentialanddispatch_for_generation.to_acceleratetosave_pretrained_wrapperaccelerateoffloading before savingsave_pretrained, and reduces excess memory usage which would cause gpu/cpu oomsHardening / Future Pre Changes
from_accelerateif possible. This guards against users who load their model outside of theload_offloaded_modelcontextoffload_devicearguemnt fromdispatch_for_sequentialto avoid deprecation warningdispatch_for_sequentialnow always respects the device the model was loaded onTesting
Qwen/Qwen3-0.6Bexample to completionunsloth/Kimi-K2-Instruct-0905-BF16example to completion