Conversation
dsikka
commented
Feb 4, 2026
- Add modifiers
Added CODEOWNERS entries for modifiers directory. Signed-off-by: Dipika Sikka <[email protected]>
|
👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review. Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed. |
Summary of ChangesHello @dsikka, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the code ownership configuration by introducing new entries for specific modifier modules within the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the CODEOWNERS file to include ownership for several modifier directories. The changes are well-structured. I've suggested a minor formatting improvement and a change to ensure consistency in ownership across related directories, as well as adding a missing path.
| /src/llmcompressor/recipe/ @shanjiaz | ||
| /src/llmcompressor/utils/ @dsikka @kylesayrs @HDCharles @brian-dellabetta | ||
|
|
||
|
|
| src/llmcompressor/modifiers/awq/ @kylesayrs @HDCharles @brian-dellabetta | ||
| src/llmcompressor/modifiers/smoothquant/ @kylesayrs @HDCharles @brian-dellabetta @rahul-tuli | ||
| src/llmcompressor/modifiers/transform/ @kylesayrs @HDCharles @brian-dellabetta | ||
| src/llmcompressor/modifiers/quantization/ @dsikka @kylesayrs @HDCharles |
There was a problem hiding this comment.
For consistency with other pytorch and utils ownership, it seems like some owners might be missing from these new entries. The owners for /src/llmcompressor/pytorch/ and /src/llmcompressor/utils/ are @dsikka @kylesayrs @HDCharles @brian-dellabetta.
It appears that:
quantizationis missing@brian-dellabetta.awq,smoothquant, andtransformare missing@dsikka.
Additionally, the src/llmcompressor/modifiers/utils/ directory seems to be missing from CODEOWNERS.
Suggesting to add the missing owners for consistency and include the modifiers/utils path.
src/llmcompressor/modifiers/awq/ @dsikka @kylesayrs @HDCharles @brian-dellabetta
src/llmcompressor/modifiers/smoothquant/ @dsikka @kylesayrs @HDCharles @brian-dellabetta @rahul-tuli
src/llmcompressor/modifiers/transform/ @dsikka @kylesayrs @HDCharles @brian-dellabetta
src/llmcompressor/modifiers/quantization/ @dsikka @kylesayrs @HDCharles @brian-dellabetta
src/llmcompressor/modifiers/utils/ @dsikka @kylesayrs @HDCharles @brian-dellabetta