Skip to content

Update CODEOWNERS to include modifiers#2329

Draft
dsikka wants to merge 1 commit intomainfrom
dsikka-codeowners
Draft

Update CODEOWNERS to include modifiers#2329
dsikka wants to merge 1 commit intomainfrom
dsikka-codeowners

Conversation

@dsikka
Copy link
Collaborator

@dsikka dsikka commented Feb 4, 2026

  • Add modifiers

Added CODEOWNERS entries for modifiers directory.

Signed-off-by: Dipika Sikka <[email protected]>
@github-actions
Copy link

github-actions bot commented Feb 4, 2026

👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review.

Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @dsikka, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the code ownership configuration by introducing new entries for specific modifier modules within the llmcompressor project. This change ensures that the appropriate teams and individuals are automatically assigned as reviewers for modifications made to these critical components, thereby streamlining the review process and enhancing code quality and accountability.

Highlights

  • CODEOWNERS Update: New entries have been added to the .github/CODEOWNERS file to assign ownership for various llmcompressor/modifiers subdirectories, specifically awq, smoothquant, transform, and quantization.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • .github/CODEOWNERS
    • Added new code ownership rules for src/llmcompressor/modifiers/awq/, assigning @kylesayrs, @HDCharles, and @brian-dellabetta.
    • Added new code ownership rules for src/llmcompressor/modifiers/smoothquant/, assigning @kylesayrs, @HDCharles, @brian-dellabetta, and @rahul-tuli.
    • Added new code ownership rules for src/llmcompressor/modifiers/transform/, assigning @kylesayrs, @HDCharles, and @brian-dellabetta.
    • Added new code ownership rules for src/llmcompressor/modifiers/quantization/, assigning @dsikka, @kylesayrs, and @HDCharles.
Activity
  • No human activity has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the CODEOWNERS file to include ownership for several modifier directories. The changes are well-structured. I've suggested a minor formatting improvement and a change to ensure consistency in ownership across related directories, as well as adding a missing path.

/src/llmcompressor/recipe/ @shanjiaz
/src/llmcompressor/utils/ @dsikka @kylesayrs @HDCharles @brian-dellabetta


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This extra blank line can be removed for conciseness. A single blank line is sufficient for separation.

Comment on lines +16 to +19
src/llmcompressor/modifiers/awq/ @kylesayrs @HDCharles @brian-dellabetta
src/llmcompressor/modifiers/smoothquant/ @kylesayrs @HDCharles @brian-dellabetta @rahul-tuli
src/llmcompressor/modifiers/transform/ @kylesayrs @HDCharles @brian-dellabetta
src/llmcompressor/modifiers/quantization/ @dsikka @kylesayrs @HDCharles
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For consistency with other pytorch and utils ownership, it seems like some owners might be missing from these new entries. The owners for /src/llmcompressor/pytorch/ and /src/llmcompressor/utils/ are @dsikka @kylesayrs @HDCharles @brian-dellabetta.

It appears that:

  • quantization is missing @brian-dellabetta.
  • awq, smoothquant, and transform are missing @dsikka.

Additionally, the src/llmcompressor/modifiers/utils/ directory seems to be missing from CODEOWNERS.

Suggesting to add the missing owners for consistency and include the modifiers/utils path.

src/llmcompressor/modifiers/awq/ @dsikka @kylesayrs @HDCharles @brian-dellabetta
src/llmcompressor/modifiers/smoothquant/ @dsikka @kylesayrs @HDCharles @brian-dellabetta @rahul-tuli
src/llmcompressor/modifiers/transform/ @dsikka @kylesayrs @HDCharles @brian-dellabetta
src/llmcompressor/modifiers/quantization/ @dsikka @kylesayrs @HDCharles @brian-dellabetta
src/llmcompressor/modifiers/utils/ @dsikka @kylesayrs @HDCharles @brian-dellabetta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments