Add AFMOE mappings for awq and smoothquant#2316
Add AFMOE mappings for awq and smoothquant#2316bartowski1182 wants to merge 7 commits intovllm-project:mainfrom
Conversation
|
👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review. Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed. |
Summary of ChangesHello @bartowski1182, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces support for AFMoE models by adding the necessary mappings for AWQ and SmoothQuant. The changes are well-contained and follow existing patterns. I've identified a minor improvement opportunity in the regular expressions used for the AWQ mappings to ensure more precise matching. Overall, the implementation is solid.
Signed-off-by: Colin Kealty <3266127+bartowski1182@users.noreply.github.com>
|
The quality checks have failed. Please run |
Signed-off-by: Colin Kealty <3266127+bartowski1182@users.noreply.github.com>
brian-dellabetta
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
|
would probably include a repro script for your test like: #2340 |
|
@HDCharles do you need me to do that or are you letting me know you'll be doing that? |
|
yeah can you add a repro script to the PR description so its clear how you tested it? |
|
also now there are conflicts |
|
This pull request has merge conflicts that must be resolved before it can be |
|
@bartowski1182 Could you please rebase on main? I'll make sure this gets in |
SUMMARY:
These mappings are needed to properly apply AWQ and smoothquant to the Trinity series of models, AfmoeForCausalLM
TEST PLAN:
Quality was tested with benchmarks, without these changes the benchmark results were extremely low, with these changes it was close to margin of error compared to bf16/FP8 dynamic
Can test on Trinity-Large-Preview
https://huggingface.co/arcee-ai/Trinity-Large-Preview