Adapt multi-turn documentation to new format#691
Adapt multi-turn documentation to new format#691oparoz wants to merge 2 commits intovllm-project:mainfrom
Conversation
sjmonson
left a comment
There was a problem hiding this comment.
Both formats are supported but I am more partial to using the arg-string format in our docs. Could you modify this PR to just fix the typo?
Yes, no problem (and good to know). I've just tested to be sure and it wouldn't work, but it was due to the inline comments. |
|
@oparoz, this project requires a linear history on feature branches. You can do this by running: |
Oh yeah, you can drop the comments since a working example is preferable. |
Yes, and that's an interesting point. Ideally, we should support copy-paste on the sample commands that are complete, and bash doesn't support comments (or anything) after the Those comments are informative, but I suspect we should remove them. |
The example for TurnPivot used the old format for `--data` Signed-off-by: Olivier Paroz <oparoz@users.noreply.github.com>
Signed-off-by: Olivier Paroz <oparoz@users.noreply.github.com>
Summary
The script in the documentation for running a multi-turn benchmark using TurnPivot had some issues
Details
Test Plan
N/A
Related Issues
N/A
Use of AI
## WRITTEN BY AI ##)