fix: sort polyfill imports for deterministic chunk hashes#21960
Open
themavik wants to merge 1 commit intovitejs:mainfrom
Open
fix: sort polyfill imports for deterministic chunk hashes#21960themavik wants to merge 1 commit intovitejs:mainfrom
themavik wants to merge 1 commit intovitejs:mainfrom
Conversation
Root cause: Set iteration order depends on insertion order, which is non-deterministic when renderChunk runs in parallel. This causes polyfill chunk hashes to differ between builds. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@vitejs/plugin-legacyproduces non-deterministic polyfill chunk hashes across buildsSetiteration depends on insertion order from parallelrenderChunkcallsRoot Cause
In
polyfillsPlugin.load(), theimportsSet is spread into an array with[...imports].map(...). SincerenderChunkhooks run in parallel, polyfills are added to the Set in non-deterministic order, producing different import sequences and thus different chunk content hashes.Fix
Sort the imports array before generating the polyfill code:
[...imports].sort().map(...). This ensures identical import order regardless ofrenderChunkexecution order.Testing
Fixes #21905
Made with Cursor