Skip to content

fix: Fixed typing for Meta configuration - #1732

Open
noamkush wants to merge 1 commit into
vitalik:masterfrom
noamkush:fix-meta-conf
Open

fix: Fixed typing for Meta configuration#1732
noamkush wants to merge 1 commit into
vitalik:masterfrom
noamkush:fix-meta-conf

Conversation

@noamkush

Copy link
Copy Markdown

This bundles a few (related) fixes into one PR:

  1. Meta.exclude is typed as a possible str but that is in no way supported
  2. Meta.fields_optional can be a "__all__" but not any other str
  3. fields_optional is typed as str but SchemaFactory isn't typed to take an str
  4. Missing mypy strict_equality which would have caught the issue in SchemaFactory
  5. Old mypy version that is incompatible with recent django-stubs - upgraded to the first supported version
  6. @no_type_check in this area - removed and fixed (or ignored) all issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant