Draft
Conversation
Also make a dependency and use FastAPI dependency injection to accept the httpx.Client instance. This also makes it much easier to test.
jonathan-d-zhang
requested changes
Apr 6, 2024
| detail = "Dragonfly Reporter service failed" | ||
| log.error(detail, status=err.response.status_code, message=err.response.text) | ||
| raise HTTPException(502, detail=detail) | ||
|
|
Comment on lines
+223
to
+225
| try: | ||
| response.raise_for_status() | ||
| except httpx.HTTPStatusError as err: |
Contributor
There was a problem hiding this comment.
Suggested change
| try: | |
| response.raise_for_status() | |
| except httpx.HTTPStatusError as err: | |
| if not response.is_success: |
| ) | ||
|
|
||
| httpx.post(f"{mainframe_settings.reporter_url}/report/{name}", json=jsonable_encoder(report)) | ||
| http_client.post(f"{mainframe_settings.reporter_url}/report/{name}", json=jsonable_encoder(report)) |
Contributor
There was a problem hiding this comment.
Don't we want to check for success here also?
| response = http_client.post(f"{mainframe_settings.reporter_url}/report/email", json=jsonable_encoder(report)) | ||
| try: | ||
| response.raise_for_status() | ||
| except httpx.HTTPStatusError as err: |
Contributor
There was a problem hiding this comment.
Let's extract the logic for error checking and sending the request to a new function so it's easier to test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contains changes from #228 + tests