Refactor proxy tunneling to use tunnelBidirectional#78
Open
Alexibu wants to merge 10 commits into
Open
Conversation
Contributor
Author
|
It relies on PRs in vibe-stream and vibe-core to compile. |
Contributor
Author
|
The functionality of this branch is broken by changes to the vibe-http trunk. If I apply the original commit 445d95c to an earlier commit it works. See proxy-fix branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous implementation of the bidirectional tunnel relied on one of the fibers being able to close the other fibers socket. This would occasionally cause a fatal assert in vibe-core net.d:768.
It is impossible to implement this correctly with out exposing waitForDataEx to allow distinguishing between data arriving, end of data and timeout. The timeout allows checking to see if the other pipe has been closed.
This way each fiber closes its own socket naturally, avoiding a race condition that can crash your server.