Concurrent decryption of secrets#301
Open
andyyu2004 wants to merge 2 commits intoviaduct-ai:masterfrom
Open
Conversation
dosubot
bot
added
size:L
|
Related Documentation Checked 3 published document(s). No updates required. How did I do? Any feedback? |
Collaborator
|
Hey @andyyu2004 appreciate the contribution! I'll review in the coming weeks. Out of curiosity many secrets are you decrypting? |
Author
|
Thanks! Only about 10, but each takes over a second since I'm quite far from the secret store. |
Author
|
Hi @devstein, a ping for review if you guys have time. I've been running this patch in production argocd for months and it seems good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ksopscan be too slow when each decrypt is slow and there are a large numbers of secrets. This uses an errgroup with a configurable limit to help.