fix(instrumentation): re-trigger require hooks for builtins after reg…#96047
Open
tabrejansary wants to merge 1 commit into
Open
fix(instrumentation): re-trigger require hooks for builtins after reg…#96047tabrejansary wants to merge 1 commit into
tabrejansary wants to merge 1 commit into
Conversation
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
| @@ -1 +1,2 @@ | |||
| export PATH="$PATH:/c/Users/Tabrej ansari/AppData/Roaming/npm" | |||
Contributor
There was a problem hiding this comment.
Suggested change
| export PATH="$PATH:/c/Users/Tabrej ansari/AppData/Roaming/npm" |
A machine-specific export PATH line hardcoding the author's Windows user directory was committed to the shared .husky/pre-commit hook.
| // Touch the built-in modules most commonly instrumented by OTel and similar | ||
| // libraries. getBuiltinModule() is synchronous and has no side effects beyond | ||
| // triggering pending require hooks. | ||
| const builtins = ['http', 'https', 'net', 'dns'] as const |
Contributor
There was a problem hiding this comment.
touchBuiltinModulesForInstrumentation() uses process.getBuiltinModule(), which bypasses Module._load and therefore never triggers require-in-the-middle hooks, making the OpenTelemetry re-patching a no-op.
Sanjays2402
reviewed
Jul 23, 2026
| @@ -1 +1,2 @@ | |||
| export PATH="$PATH:/c/Users/Tabrej ansari/AppData/Roaming/npm" | |||
There was a problem hiding this comment.
this looks like it got committed by accident — a hardcoded local npm path with your username. drop it from the PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ister (#95894)