turbo-tasks-backend: add TaskAccess (MaybeCreate/MustExist) to task lookups#96043
Draft
lukesandberg wants to merge 1 commit into
Draft
turbo-tasks-backend: add TaskAccess (MaybeCreate/MustExist) to task lookups#96043lukesandberg wants to merge 1 commit into
lukesandberg wants to merge 1 commit into
Conversation
…ookups Replace the implicit create-on-miss behavior of ExecuteContext::task with an explicit TaskAccess argument so every call site declares intent: - MaybeCreate: open-or-create (today's behavior) — creation and edge-follows. - MustExist: the task must already exist (resident or on disk); fabricating a blank for a nonexistent task is a bug. The existence check is debug-only for now (panics in debug, falls back to create in release) and will be promoted once the call-site classification is proven. lookup_data now reports DB-key presence and restore_task_data threads it through so a MustExist open can refuse to fabricate. task_pair also takes TaskAccess. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This was referenced Jul 22, 2026
Contributor
Tests PassedCommit: ee0a2e0 |
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
Stats from current PRWarning No stats were collected for Webpack because its stats job did not complete (it failed, was cancelled, or timed out). The results below only cover the bundlers that finished. 🟢 1 improvement
📊 All Metrics📖 Metrics GlossaryDev Server Metrics:
Build Metrics:
Change Thresholds:
⚡ Dev Server
⚡ Production Builds
📦 Production Builds (Webpack) (Legacy)📦 Production Builds (Webpack)
📦 Bundle SizesBundle Sizes⚡ TurbopackClient Main Bundles
Server Middleware
Build DetailsBuild Manifests
🔄 Shared (bundler-independent)Runtimes
📝 Changed Files (29 files)Files with changes:
View diffsapp-page-exp..ntime.dev.jsfailed to diffapp-page-exp..time.prod.jsfailed to diffapp-page-tur..ntime.dev.jsfailed to diffapp-page-tur..time.prod.jsfailed to diffapp-page-tur..ntime.dev.jsfailed to diffapp-page-tur..time.prod.jsfailed to diffapp-page.runtime.dev.jsfailed to diffapp-page.runtime.prod.jsfailed to diffapp-route-ex..ntime.dev.jsDiff too large to display app-route-ex..time.prod.jsDiff too large to display app-route-tu..ntime.dev.jsDiff too large to display app-route-tu..time.prod.jsDiff too large to display app-route-tu..ntime.dev.jsDiff too large to display app-route-tu..time.prod.jsDiff too large to display app-route.runtime.dev.jsDiff too large to display app-route.ru..time.prod.jsDiff too large to display pages-api-tu..ntime.dev.jsDiff too large to display pages-api-tu..time.prod.jsDiff too large to display pages-api.runtime.dev.jsDiff too large to display pages-api.ru..time.prod.jsDiff too large to display pages-turbo...ntime.dev.jsDiff too large to display pages-turbo...time.prod.jsDiff too large to display pages.runtime.dev.jsDiff too large to display pages.runtime.prod.jsDiff too large to display server.runtime.prod.jsDiff too large to display use-cache-pr..ntime.dev.jsDiff too large to display use-cache-pr..ntime.dev.jsDiff too large to display use-cache-pr..ntime.dev.jsDiff too large to display use-cache-pr..ntime.dev.jsDiff too large to display 📎 Tarball URLCommit: ee0a2e0 |
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
| category: TaskDataCategory, | ||
| access: TaskAccess, | ||
| ) -> (Self::TaskGuardImpl, Self::TaskGuardImpl) { | ||
| // `access` is consumed by the GC layer above this branch |
Contributor
There was a problem hiding this comment.
task_pair discards its TaskAccess parameter with a comment referencing a non-existent "GC layer", so the debug-only MustExist existence check that open performs is silently not applied to the two-task locking path.
lukesandberg
commented
Jul 22, 2026
| let task_id = chain.last().unwrap(); | ||
| let error = { | ||
| let task = ctx.task(*task_id, TaskDataCategory::Meta); | ||
| let task = ctx.task(*task_id, TaskDataCategory::Meta, TaskAccess::MaybeCreate); |
Contributor
Author
There was a problem hiding this comment.
this should be MustExist, we a recovering an error referencing a task id for a task that previously failed
lukesandberg
commented
Jul 22, 2026
Comment on lines
649
to
+656
|
|
||
| for (child_task_id, count) in children { | ||
| let task_description = ctx | ||
| .task(child_task_id, TaskDataCategory::Data) | ||
| .task( | ||
| child_task_id, | ||
| TaskDataCategory::Data, | ||
| TaskAccess::MaybeCreate, | ||
| ) |
Contributor
Author
There was a problem hiding this comment.
lukesandberg
commented
Jul 22, 2026
| let dependent = ctx.task( | ||
| dependent_task_id, | ||
| TaskDataCategory::All, | ||
| TaskAccess::MaybeCreate, |
Contributor
Author
There was a problem hiding this comment.
dependents must exist
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Annotate each task access with an assertion whether or not we allow a task to be created