fix(dashboard): Use index-based identification for collection filters

[grolmus]

Summary

• Fixed collection filters with the same type sharing state incorrectly
• Changed onOperationValueChange to use index-based identification instead of code-based
• Enabled the existing regression test for this issue

The bug was in configurable-operation-multi-selector.tsx where filters were identified by code, causing all filters of the same type to update when any one changed.

Test plan

• Manually verified fix in dashboard (added 2 "Filter by product variant name" filters with different values)
• CI runs issue-4327-collection-filter-state.spec.ts regression test

Fixes #4327

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
vendure-storybook	Ready	Preview, Comment	Feb 26, 2026 2:13pm

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0f1dec5 and ae0e8eb.

📒 Files selected for processing (2)

• packages/dashboard/e2e/tests/regression/issue-4327-collection-filter-state.spec.ts
• packages/dashboard/src/lib/components/shared/configurable-operation-multi-selector.tsx

---

📝 Walkthrough

Walkthrough

This pull request addresses a state management bug in collection filters where multiple filters of the same type incorrectly shared synchronized values. The fix involves two key changes: (1) activating a regression test in the test suite that validates the independent state of multiple same-type filters, and (2) refactoring the ConfigurableOperationMultiSelector component to use index-based identification instead of code-based identification when updating filter values. This ensures each filter instance maintains its own state regardless of type.

Suggested reviewers

• michaelbromley

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically describes the main change: using index-based identification for collection filters instead of code-based identification.
Description check	✅ Passed	The description includes a summary of changes, explains the bug fix, references the issue, includes a test plan with manual verification notes, and covers the key implementation details.
Linked Issues check	✅ Passed	The code changes fully address issue #4327 by replacing code-based filter identification with index-based identification in onOperationValueChange and enabling the regression test.
Out of Scope Changes check	✅ Passed	All changes are directly scoped to fixing issue #4327: the index-based callback in configurable-operation-multi-selector.tsx and enabling the related regression test.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[biggamesmallworld]

Hey @grolmus, nice fix! The logic change is correct and clean.

The dashboard e2e failure is a small casing issue in the test. The variant-name-filter's term argument has no explicit label, so the UI falls back to the argument name "term" (lowercase). The test is looking for 'Term' (capitalized).

In issue-4327-collection-filter-state.spec.ts, lines 33 and 43:

- has: page.getByText('Term', { exact: true }),
+ has: page.getByText('term', { exact: true }),

That should get CI green. 🙂

[biggamesmallworld]

LGTM — the index-based fix is correct and consistent with the existing patterns in the component. The test casing issue has been identified and a fix provided in the comments.