async support added for storagePath() function#909
Open
codeonprod wants to merge 2 commits intoveliovgroup:devfrom
Open
async support added for storagePath() function#909codeonprod wants to merge 2 commits intoveliovgroup:devfrom
codeonprod wants to merge 2 commits intoveliovgroup:devfrom
Conversation
jankapunkt
reviewed
Nov 27, 2025
| * @returns {Promise<void>} | ||
| * @private | ||
| */ | ||
| async _ensureStoragePath() { |
Collaborator
There was a problem hiding this comment.
This method is added but nowhere used. What's its purpose?
Author
There was a problem hiding this comment.
That function's content was earlier used inside the constructor to check the existence of the path provided. it was async to check so causing issue while making FilesCollection object. so, moved to separate function. The end user will have flexibility to call this searately if needed.
Author
There was a problem hiding this comment.
its primary purpose is to create directory of not exists.
test cases updated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I’m using ostrio:files in a Meteor project and ran into a limitation regarding
storagePath().Current behavior
storagePath()is called synchronously, which makes it impossible to compute the value using asynchronous operations.Example use cases where async is required:
Right now, returning a Promise or using async/await inside storagePath() does not work — the function must return a string immediately.
Impact
This prevents:
Desired behavior
Allow
storagePath()to be asynchronous.Example idea: