Populate timestamp in LinControllerStatusUpdate message#297
Merged
snps-kratz merged 3 commits intomainfrom Mar 9, 2026
Merged
Conversation
…erStatusInternal Signed-off-by: Felix Kratz <[email protected]>
Signed-off-by: Felix Kratz <[email protected]>
snps-kratz
force-pushed
the
lin_controller_status_timestamp
branch
from
35d66d6 to
0548b12
Compare
VDanielEdwards
approved these changes
Mar 9, 2026
Member
VDanielEdwards
left a comment
VDanielEdwards
left a comment
There was a problem hiding this comment.
The only thing I'd add is making sure that the message is initialized (see the comment, just in case we add any fields in the future). Otherwise LGTM!
Co-authored-by: Daniel Edwards <[email protected]> Signed-off-by: Felix Kratz <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Subject
Initializes the
timestampvariable on theLinControllerStatusUpdatemessage send inLinController::SetControllerStatusInternal.Adds test conditions that check the timestamp of the
LinControllerStatusUpdatemessage.Description
This change fixes inconsistent logging behavior for trace logs. Originally, the timestamp field was uninitialized, leading to trace logs with timestamps that would not match simulation timestamps.
Additionally, this change populates the timestamp received by network simulators in
OnControllerStatusUpdatefunction calls.Instructions for review / testing
Since the tests have been changed, correctness in those should be focused.
Developer checklist (address before review)