feat(api): add GetCapabilities RPC to expose allocation tracing status and metric names#25427
feat(api): add GetCapabilities RPC to expose allocation tracing status and metric names#25427thomasqueirozb wants to merge 11 commits into
Conversation
…s and metric names
thomasqueirozb
added
the
no-changelog
thomasqueirozb
removed
the
no-changelog
| } | ||
|
|
||
| enum InternalMetricKind { | ||
| INTERNAL_METRIC_KIND_UNSPECIFIED = 0; |
There was a problem hiding this comment.
Not sure if this is needed. Maybe we remove this and shift INTERNAL_METRIC_KIND_COUNTER to be 0 instead
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8971fc3af7
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a03d056a4f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
1 participant
Summary
Adds a
GetCapabilitiesRPC to the Vector observability gRPC API. This givesvector top(and any other client) a single call at connection time to discover:CounterName,GaugeName, andHistogramNameenumsThe
InternalMetricKindenum is defined invector-common(co-located with the name enums) and mirrored in the proto.vector topcallsGetCapabilitiesonce per connection ininit_components(), populatingState::available_metrics. On older servers that don't implement this RPC, it falls back toGetAllocationTracingStatusfor the allocation tracing flag and populatesavailable_metricsfrom the compiled-in metric name enums.Vector configuration
NA
How did you test this PR?
NA
Change Type
Is this a breaking change?
Does this PR include user facing changes?
no-changeloglabel to this PR.References
NA