chore(deps): bump redis from 0.32.5 to 1.2.0#25306
Conversation
dependabot
Bot
added
domain: deps
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ca3480097f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| [[package]] | ||
| name = "redis" | ||
| version = "0.32.5" | ||
| version = "1.2.0" |
There was a problem hiding this comment.
Cargo.lock now pins redis to 1.2.0, but the workspace manifest still requires redis = ^0.32.4 (Cargo.toml:424). When features that enable dep:redis are resolved, Cargo must rewrite the lockfile back to a 0.32.x version, which trips the repo’s rust check guard that fails if Cargo.lock changes during cargo runs (vdev/src/commands/check/rust.rs:63-77). In practice this makes dependency checks/CI unstable until the manifest constraint is updated in tandem with the lockfile bump.
Useful? React with 👍 / 👎.
dependabot
Bot
force-pushed
the
dependabot/cargo/redis-1.2.0
branch
6 times, most recently
from
f7df705 to
d7bdacc
Compare
dependabot
Bot
force-pushed
the
dependabot/cargo/redis-1.2.0
branch
from
d7bdacc to
5e47555
Compare
💡 Codex ReviewLine 9434 in 5e47555 Update redis call sites before pinning 1.x
With the default feature set, ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
dependabot
Bot
force-pushed
the
dependabot/cargo/redis-1.2.0
branch
4 times, most recently
from
68e8b40 to
a387ddd
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a387ddd632
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| [[package]] | ||
| name = "redis" | ||
| version = "0.32.5" | ||
| version = "1.2.0" |
There was a problem hiding this comment.
After this bump is made effective, the default Redis features won't compile against redis 1.x: the 1.2 docs show ConnectionInfo/RedisConnectionInfo as private-field structs and ConnectionAddr as non-exhaustive, but Vector still reads redis_conn_info.addr in src/sources/redis/mod.rs:80 and constructs RedisConnectionInfo { db, username, ... } in src/sinks/redis/config.rs:327. Please migrate those call sites to the new accessor/setter APIs (or keep the lock on 0.32.x) as part of the dependency bump.
Useful? React with 👍 / 👎.
dependabot
Bot
force-pushed
the
dependabot/cargo/redis-1.2.0
branch
from
a387ddd to
d9dd727
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d9dd727864
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| name = "arcstr" | ||
| version = "1.2.0" | ||
| source = "registry+https://github.com/rust-lang/crates.io-index" | ||
| checksum = "03918c3dbd7701a85c6b9887732e2921175f26c350b4563841d0958c21d57e6d" |
There was a problem hiding this comment.
When this dependency bump is made effective, redis now pulls in the new arcstr crate, but LICENSE-3rdparty.csv has not been regenerated and contains no arcstr entry. The repo’s make check-licenses target runs dd-rust-license-tool check to enforce that file is up to date, so CI/license checks will fail until the generated third-party license file is updated alongside the lockfile.
Useful? React with 👍 / 👎.
dependabot
Bot
force-pushed
the
dependabot/cargo/redis-1.2.0
branch
3 times, most recently
from
7f9e12e to
f628b98
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f628b9822e
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| [[package]] | ||
| name = "redis" | ||
| version = "0.32.5" | ||
| version = "1.2.0" |
There was a problem hiding this comment.
When sources-redis uses an empty list, Vector calls brpop/blpop with 0.0 to block indefinitely, but redis 1.x async connections now default response_timeout to 500ms unless the connection is built with AsyncConnectionConfig::set_response_timeout(None). Since the source still creates its ConnectionManager with the default config, this bump makes an idle Redis source time out, reconnect, and emit errors twice per second instead of waiting for the next item.
Useful? React with 👍 / 👎.
dependabot
Bot
force-pushed
the
dependabot/cargo/redis-1.2.0
branch
from
f628b98 to
2413e77
Compare
Bumps [redis](https://github.com/redis-rs/redis-rs) from 0.32.5 to 1.2.0. - [Release notes](https://github.com/redis-rs/redis-rs/releases) - [Commits](redis-rs/redis-rs@redis-0.32.5...redis-1.2.0) --- updated-dependencies: - dependency-name: redis dependency-version: 1.2.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
force-pushed
the
dependabot/cargo/redis-1.2.0
branch
from
2413e77 to
f849f5a
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f849f5a011
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| [[package]] | ||
| name = "redis" | ||
| version = "0.32.5" | ||
| version = "1.2.0" |
There was a problem hiding this comment.
When this bump is made effective, Redis 1.x ConnectionManagerConfig defaults command response_timeout to 500ms, but the Redis sink still creates both direct and sentinel managers with get_connection_manager() (src/sinks/redis/config.rs:241-243, src/sinks/redis/sink.rs:95-98) while Vector exposes request.timeout_secs with a 60s default. In environments where Redis is slow or large batches take longer than 500ms, LPUSH/ZADD/PUBLISH requests will fail and retry before the configured Vector timeout is reached, so the sink's timeout setting is effectively ignored unless the manager is built with an explicit response timeout (for example None or the configured request timeout).
Useful? React with 👍 / 👎.
Bumps redis from 0.32.5 to 1.2.0.
Release notes
Sourced from redis's releases.
... (truncated)
Commits
4508a29Prepare next version (#2038)66aeef4Don't compile tokio runtime when using smol (#2036)929469bREADME: Add stanza about AI contributions (#2033)8b9c124Bump anyhow from 1.0.100 to 1.0.102 (#2024)b21b196Add strategies for routing reads to cluster replicas (#1985)ec8d6fcBump tokio-util from 0.7.17 to 0.7.18 (#2023)124f4a2Bump async-trait from 0.1.88 to 0.1.89 (#2025)a0fdd4cBump itoa from 1.0.17 to 1.0.18 (#2026)8c4349aBump env_logger from 0.11.8 to 0.11.10 (#2027)f392b28Bump async-io from 2.4.0 to 2.6.0 (#2029)