Add support for @position-try rules types#1589
Open
lfantone wants to merge 1 commit intovanilla-extract-css:masterfrom
Open
Add support for @position-try rules types#1589lfantone wants to merge 1 commit intovanilla-extract-css:masterfrom
@position-try rules types#1589lfantone wants to merge 1 commit intovanilla-extract-css:masterfrom
Conversation
🦋 Changeset detectedLatest commit: e57d693 The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
5638794 to
e57d693
Compare
|
why is this API so different from |
Contributor
I was going to do a proper review and bring up the same issue. This should really be a proper API like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CSS Anchor Positioning specification defines specific requirements for the
@position-tryat-rule.<dashed-ident>format with double dash prefix (--custom-name)@position-tryblocksChanges
Type improvements
PositionTryPropertiestype to explicitly list allowed properties according to the spec:top,right,bottom,left,inset)margin,marginTop, etc.)width,height,minWidth, etc.)alignSelf,justifySelf)positionAnchor,positionArea)PositionTryQuerytype that enforces position names must start with double dash (--)Runtime validation
transformPositionTryto ensure position names start with double dash (--)Relates to #1566 and full implementation depends on #1587.