Debug id for custom identifiers#1229
Open
ufaubion-oracle wants to merge 3 commits intovanilla-extract-css:masterfrom
Open
Debug id for custom identifiers#1229ufaubion-oracle wants to merge 3 commits intovanilla-extract-css:masterfrom
ufaubion-oracle wants to merge 3 commits intovanilla-extract-css:masterfrom
Conversation
🦋 Changeset detectedLatest commit: 3d04b52 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
As discussed in the discord thread linked in the issue, I don't think that the best solution is just enabling it for everything except I think ideally the custom identifier function would be separate to the debug identifier option. There could be a bit of nuance here if we want to avoid a breaking change in every integration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR created to resolve #1228
Details:
I changed integrations transformer code to only skip "@vanilla-extract/babel-plugin-debug-ids" when the
identOption !== 'short'.